-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the workflow ID cache in shadow mode for start workflow #5641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
January 31, 2024 11:30
Pull Request Test Coverage Report for Build 018d78b0-b145-4e15-af9f-9e599c95a65a
💛 - Coveralls |
sankari165
reviewed
Feb 1, 2024
davidporter-id-au
approved these changes
Feb 2, 2024
…call is made but does not affect the execution of the method
3vilhamster
reviewed
Feb 5, 2024
3vilhamster
reviewed
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Enable the workflowID cache in shadow mode for startWorkflow only - still disabled by default by dynamic config
Why?
Enabling in shadow mode to see the behaviour before enabling fully
How did you test it?
Tested locally
Potential risks
The risk should be small as it is guarded by a dynamic config feature flag
Release notes
Documentation Changes