Rewrite async workflow queue provider component #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
force-pushed
the
async-provider
branch
from
d8101ac to
d2f6104
Compare
taylanisikdemir
approved these changes
Feb 8, 2024
|
|
||
| func (d *decoderImpl) Decode(out any) error { | ||
| if d.blob.GetEncodingType() != types.EncodingTypeJSON { | ||
| return fmt.Errorf("unsupported encoding type %v", d.blob.GetEncodingType()) |
There was a problem hiding this comment.
let's mention supported encoding types in the error message
| // PutIfNotExist is thread safe, and will either return the value that was already in the cache or the value we just created | ||
| // another thread might have inserted a value between the Get and PutIfNotExist, but that is ok | ||
| // it should never return an error as we do not use Pin | ||
| val, err = q.producerCache.PutIfNotExist(queueID, producer) |
There was a problem hiding this comment.
side comment: a better semantic for this would be PutIfNotExist(key string, valueCreator func() any) so we could avoid the potential duplicate initialization problem
There was a problem hiding this comment.
that requires rewriting cache implementation, will not do it in this pr
Shaddoll
force-pushed
the
async-provider
branch
from
d2f6104 to
bb1cecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Rewrite async workflow queue provider component
Why?
The old design doesn't support our use case
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes