Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pinot query to use unix milliseconds instead of nano #5650

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Feb 8, 2024

What changed?
Convert time units to milliseconds from nanoseconds for pinot query

Why?
By default it is passing nano seconds from frontend

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

common/pinot/pinotQueryValidator.go Outdated Show resolved Hide resolved
common/pinot/pinotQueryValidator.go Outdated Show resolved Hide resolved
common/pinot/pinotQueryValidator.go Outdated Show resolved Hide resolved
common/pinot/pinotQueryValidator.go Outdated Show resolved Hide resolved
common/pinot/pinotQueryValidator.go Outdated Show resolved Hide resolved
common/pinot/pinotQueryValidator.go Outdated Show resolved Hide resolved
common/pinot/pinotQueryValidator_test.go Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 9, 2024

Pull Request Test Coverage Report for Build 018d8fc5-fc12-4b7b-ad3d-9526466dcf69

  • -6 of 54 (88.89%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.06%) to 62.725%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/pinot/pinotQueryValidator.go 48 54 88.89%
Files with Coverage Reduction New Missed Lines %
common/task/parallel_task_processor.go 2 93.06%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/shard/context.go 2 66.52%
service/history/task/timer_task_executor_base.go 2 78.38%
service/history/task/transfer_active_task_executor.go 2 72.24%
service/history/task/transfer_standby_task_executor.go 2 87.86%
service/matching/matcher.go 2 90.72%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/task/fetcher.go 4 86.08%
service/history/task/task_util.go 4 75.14%
Totals Coverage Status
Change from base Build 018d8e81-8a83-4fc7-b54e-ed48a13d340b: 0.06%
Covered Lines: 92324
Relevant Lines: 147189

💛 - Coveralls

Copy link
Contributor

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neil-xie neil-xie enabled auto-merge (squash) February 9, 2024 21:29
@neil-xie neil-xie merged commit 9b15cd1 into cadence-workflow:master Feb 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants