Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pinot query validator bug when user pass in not equal query with value missing #5662

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix Pinot query validator bug when user pass in not equal query with value missing #5662

merged 2 commits into from
Feb 14, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Pinot can not handle CloseTime != missing case, only handled equal string

Why?

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Feb 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 018da92c-f4d7-4c29-928e-fb80bf2c7957

Details

  • 0 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 57 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.006%) to 62.753%
Files with Coverage Reduction New Missed Lines %
service/matching/matcher.go 1 91.07%
common/task/fifo_task_scheduler.go 2 87.63%
common/util.go 2 91.69%
service/history/execution/mutable_state_builder.go 2 68.64%
service/matching/taskListManager.go 2 80.96%
service/history/queue/timer_gate.go 3 95.83%
service/history/task/fetcher.go 4 86.08%
service/history/task/task_util.go 4 75.14%
service/history/task/transfer_standby_task_executor.go 4 87.01%
common/persistence/sql/workflowStateMaps.go 11 85.56%
Totals Coverage Status
Change from base Build 018da915-7c09-4be4-ab8e-cc6a8d62a77e: 0.006%
Covered Lines: 92616
Relevant Lines: 147588
💛 - Coveralls

bowenxia
bowenxia approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@bowenxia bowenxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidporter-id-au
Copy link
Member

Would it be useful building a bank of existing test cases from queries to test against?

@neil-xie neil-xie merged commit 30ffa2d into cadence-workflow:master Feb 14, 2024
16 checks passed
@neil-xie neil-xie deleted the CDNC_6940 branch February 14, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenxia bowenxia bowenxia approved these changes

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@Groxx Groxx Awaiting requested review from Groxx

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neil-xie @coveralls @davidporter-id-au @taylanisikdemir @bowenxia