[cassandra] Expose timeout and consistency level configuration #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantas-sidlauskas
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018f104c-e659-4aeb-806d-f0bfe091ee6bDetails
💛 - Coveralls |
mantas-sidlauskas
force-pushed
the
gocql_config
branch
from
3463fcf to
f519140
Compare
Comment on lines
116
to
117
| Consistency: gocql.ParseConsistency(cfg.Consistency), | ||
| SerialConsistency: gocql.ParseSerialConsistency(cfg.SerialConsistency), |
There was a problem hiding this comment.
can you change these functions to return err instead of panicing? I know toGoCqlConfig is not returning error but it's only caller is doCreateDB which returns error so we can propagate these errors.
There was a problem hiding this comment.
PR for this change: #5811
mantas-sidlauskas
force-pushed
the
gocql_config
branch
2 times, most recently
from
89efbd7 to
6ddc5fc
Compare
mantas-sidlauskas
force-pushed
the
gocql_config
branch
2 times, most recently
from
f177e99 to
6c2bd56
Compare
taylanisikdemir
approved these changes
Apr 23, 2024
Codecov Report
Additional details and impacted files
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mantas-sidlauskas
force-pushed
the
gocql_config
branch
from
30bbea5 to
33836b4
Compare
mantas-sidlauskas
force-pushed
the
gocql_config
branch
from
e6cefc5 to
e3509ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allow to change timeout and consistency levels for Cassandra connections.
Default hardcoded values will be applied if no values are provided in configuration
Why?
There was no way to change hard-coded defaults.
How did you test it?
Potential risks
Release notes
Documentation Changes