-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage for constants.go #5685
Conversation
expectedDescription string | ||
expectedFilters []Filter | ||
}{ | ||
"TestGetIntPropertyKey": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you planning to cover the rest of the keys in follow up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really as variable definition is not included in code coverage and including all keys will be essentially parsed structs in constants.go.
Pull Request Test Coverage Report for Build 018dd2bc-79e9-4dee-8915-4c48de3531d2Details
💛 - Coveralls |
What changed?
Add unit tests for IntKey, BoolKey, FloatKey, StringKey, MapKey, DurationKey, and ListKey.
Why?
improve test coverage
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes