Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for Delete current and workflow execution, list all … #5733

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

agautam478
Copy link
Contributor

…current workflows

What changed?

  • Added tests for the following functions:
    DeleteWorkflowExecution, DeleteCurrentWorkflowExecution, and ListCurrentExecutions.

Each function contains one success and one failure case.

Why?
To increase code coverage

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 018e159a-431e-47be-b9e4-2431a3660106

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 128 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.03%) to 63.758%

Files with Coverage Reduction New Missed Lines %
common/persistence/executionManager.go 2 78.59%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/execution/mutable_state_util.go 2 78.48%
service/history/task/transfer_standby_task_executor.go 4 86.6%
common/persistence/statsComputer.go 5 94.64%
service/history/task/fetcher.go 5 85.57%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 63.03%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018e157c-5c3f-4318-8ae8-5977fc7f38b7: -0.03%
Covered Lines: 93468
Relevant Lines: 146599

💛 - Coveralls

@agautam478 agautam478 enabled auto-merge (squash) March 6, 2024 21:11
@agautam478 agautam478 merged commit 8f5bc04 into cadence-workflow:master Mar 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants