Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more tests for cassandra/workflows.go #5750

Conversation

taylanisikdemir
Copy link
Member

What changed?
Continuing to add more tests to cassandra/workflows.go. More to come.

Why?
Increase coverage

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 018e1a47-5f1d-4aef-9589-b7fddee69429

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 59 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.03%) to 63.937%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/matching/taskListManager.go 2 79.7%
common/util.go 2 91.69%
common/persistence/executionManager.go 2 78.59%
common/membership/hashring.go 2 82.23%
service/history/task/fetcher.go 3 86.6%
service/history/queue/timer_queue_processor_base.go 3 77.82%
common/task/fifo_task_scheduler.go 5 84.54%
common/persistence/statsComputer.go 5 94.64%
service/history/shard/context.go 9 66.84%
Totals Coverage Status
Change from base Build 018e1a2e-085a-41ae-9444-fc353ea4c336: 0.03%
Covered Lines: 93731
Relevant Lines: 146599

💛 - Coveralls

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5750 (40d9a3d) into master (50eedfa) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 40d9a3d differs from pull request most recent head 8a96f40. Consider uploading reports for the commit 8a96f40 to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50eedfa...8a96f40. Read the comment docs.

@taylanisikdemir taylanisikdemir force-pushed the taylan/workflows_more_tests branch from 40d9a3d to 8a96f40 Compare March 7, 2024 18:57
@taylanisikdemir taylanisikdemir merged commit b2db40e into cadence-workflow:master Mar 7, 2024
18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/workflows_more_tests branch March 7, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants