-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test for replicationTaskExecutor: execute #5754
Conversation
Codecov Report
Additional details and impacted filessee 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e1b28-6edc-4a2a-a6c7-b2b11a42641bDetails
💛 - Coveralls |
@@ -0,0 +1,864 @@ | |||
// Copyright (c) 2017 Uber Technologies, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename the files with snake_case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is filename_test.
If we change even the file name to snake case, it will be inconsistent throughout.
Description:
Contains unit tests for the
domainReplicationTaskExecutorImpl
's Execute method, covering domain creation, update, name/UUID collision, and handling of unsupported domain operations.The tests utilize mocking to simulate DomainManager interactions.
Why?:
Improved test coverage for domain replication task execution ensures robust handling of domain operations across different scenarios.
How did you test it?:
The added unit tests were executed locally, with all tests passing. Mocks were employed to simulate the DomainManager interactions.
Potential risks:
Minimal risk is associated with this PR as it primarily adds unit tests without altering the core logic of domain replication task execution.