Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for replicationTaskExecutor: execute #5754

Merged
merged 8 commits into from
Mar 8, 2024

Conversation

abhishekj720
Copy link
Contributor

@abhishekj720 abhishekj720 commented Mar 7, 2024

Description:
Contains unit tests for the domainReplicationTaskExecutorImpl's Execute method, covering domain creation, update, name/UUID collision, and handling of unsupported domain operations.
The tests utilize mocking to simulate DomainManager interactions.

Why?:
Improved test coverage for domain replication task execution ensures robust handling of domain operations across different scenarios.

How did you test it?:
The added unit tests were executed locally, with all tests passing. Mocks were employed to simulate the DomainManager interactions.

Potential risks:
Minimal risk is associated with this PR as it primarily adds unit tests without altering the core logic of domain replication task execution.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5754 (f40b431) into master (856145b) will increase coverage by 0.12%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head f40b431 differs from pull request most recent head 64b4c07. Consider uploading reports for the commit 64b4c07 to get more accurate results

Additional details and impacted files

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e00cb...64b4c07. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 018e1b28-6edc-4a2a-a6c7-b2b11a42641b

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 130 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.04%) to 63.228%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/common.go 2 46.75%
common/persistence/sql/sql_task_store.go 2 54.32%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/util.go 2 91.69%
common/persistence/executionManager.go 2 78.59%
common/membership/hashring.go 2 82.23%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 71.41%
common/task/fifo_task_scheduler.go 4 80.41%
Totals Coverage Status
Change from base Build 018e1af5-7c55-428d-9cce-978e3813e7da: -0.04%
Covered Lines: 92692
Relevant Lines: 146599

💛 - Coveralls

@abhishekj720 abhishekj720 enabled auto-merge (squash) March 7, 2024 21:44
@@ -0,0 +1,864 @@
// Copyright (c) 2017 Uber Technologies, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename the files with snake_case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is filename_test.
If we change even the file name to snake case, it will be inconsistent throughout.

@abhishekj720 abhishekj720 merged commit cdc3212 into cadence-workflow:master Mar 8, 2024
18 checks passed
@abhishekj720 abhishekj720 deleted the testrte branch March 8, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants