Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pinot_visibility_store_test #5780

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Mar 13, 2024

What changed?
refactor pinot_visibility_store_test.
factored out mocks and pass those in as table test params.

Why?
refactor pinot_visibility_store_test to follow a better practice just like this one: #5777

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #5780 (65265bf) into master (c6a10dc) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a10dc...65265bf. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e3544-0501-42f8-be95-9f1ebe44886f

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 80 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.02%) to 64.88%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
service/history/task/transfer_standby_task_executor.go 2 86.19%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
client/history/client.go 2 35.78%
service/history/handler/handler.go 2 49.59%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 72.38%
common/util.go 2 91.69%
common/membership/hashring.go 2 82.23%
Totals Coverage Status
Change from base Build 018e341f-2cdc-43b3-a7ef-6d5189e3d4cd: 0.02%
Covered Lines: 94589
Relevant Lines: 145791

💛 - Coveralls

@bowenxia bowenxia enabled auto-merge (squash) March 13, 2024 03:57
@bowenxia bowenxia merged commit 227e27f into master Mar 13, 2024
21 checks passed
@bowenxia bowenxia deleted the xbowen_pinotVisibilityStoreTest_refactor branch March 13, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants