Ignore requests send from pinot response comparator #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
neil-xie
reviewed
Mar 14, 2024
| @@ -329,11 +329,16 @@ type userParameters struct { | |||
|
|
|||
| // For Pinot Migration uses. It will be a temporary usage | |||
| // logUserQueryParameters will log user queries' parameters so that a comparator workflow can consume | |||
| func (v *pinotVisibilityTripleManager) logUserQueryParameters(userParam userParameters, domain string) { | |||
| func (v *pinotVisibilityTripleManager) logUserQueryParameters(userParam userParameters, domain string, override bool) { | |||
| // Don't log if it is not enabled | |||
| if !v.logCustomerQueryParameter(domain) { | |||
There was a problem hiding this comment.
we can combine this with override check if !v.logCustomerQueryParameter(domain) || override {}
There was a problem hiding this comment.
Sure. I was thinking to make it more readable
neil-xie
approved these changes
Mar 14, 2024
Codecov Report
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e3ef5-a875-4e94-a872-25a78e48b097Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Ignored the requests sent from Pinot Response Comparator
Why?
If we don't ignore, we will have duplicated data.
How did you test it?
Potential risks
Release notes
Documentation Changes