Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error mapper tests #5795

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Mar 19, 2024

What changed?

  • Refactored the error test in the proto mapper
  • Added test to make sure all fields are set in the test errors (if not, the check will pass, even though data would be lost).
  • Added tests for the thrift mapper

Why?
Make sure data is preserved in the mappings

How did you test it?
It's a test in itself.

Potential risks

Release notes

Documentation Changes

@jakobht jakobht changed the title Refactor protobuf error test Error mapper tests Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #5795 (4bdf9d6) into master (c521fa3) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 4bdf9d6 differs from pull request most recent head 2f97f16. Consider uploading reports for the commit 2f97f16 to get more accurate results

Additional details and impacted files

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c521fa3...2f97f16. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e56c4-476c-4f8a-9637-fbaaf58a6298

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 47 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.09%) to 65.117%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.01%
service/matching/taskReader.go 2 84.88%
common/task/parallel_task_processor.go 2 93.06%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/matcher.go 2 90.72%
service/history/execution/mutable_state_util.go 2 78.48%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
Totals Coverage Status
Change from base Build 018e54d9-e65f-41e4-8b52-ba7cf9f63307: 0.09%
Covered Lines: 95175
Relevant Lines: 146160

💛 - Coveralls

@jakobht jakobht merged commit b04f984 into cadence-workflow:master Mar 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants