Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric and retry backoff for checksum failure #5797

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Add metric and retry backoff for checksum failure

Why?

  • backoff a small period of time to give some time for the database to get refresh data
  • add a metric to track the number of stale reads which aren't mitigated by the retry logic

How did you test it?

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll enabled auto-merge (squash) March 19, 2024 18:11
@Shaddoll Shaddoll merged commit 5ff845e into cadence-workflow:master Mar 19, 2024
18 checks passed
@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 018e57be-d364-4a21-baf7-abad984c73ee

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 65.119%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/execution/context.go 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
service/history/execution/context.go 1 68.08%
service/history/task/transfer_standby_task_executor.go 2 87.01%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/fifo_task_scheduler.go 2 87.63%
service/history/execution/mutable_state_builder.go 2 70.3%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/queue/timer_gate.go 3 95.83%
Totals Coverage Status
Change from base Build 018e57d2-73cf-4c4c-be3d-a60180509d80: 0.03%
Covered Lines: 95182
Relevant Lines: 146167

💛 - Coveralls

@Shaddoll Shaddoll deleted the checksum branch March 19, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants