Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetListWorkflowExecutionsByStatusQuery to set status as int #5936

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Currently when it builds the query, it sets CloseStatus as string which is not matched with Pinot schema and can cause query failure.

Why?
Bug fix

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #5936 (3f4c609) into master (44b1f59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
common/persistence/pinot/pinot_visibility_store.go 93.23% <100.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b1f59...3f4c609. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 23, 2024

Pull Request Test Coverage Report for Build 018f0e2c-f830-4bfa-ac45-867d028eedb9

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 51 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.004%) to 67.684%

Files with Coverage Reduction New Missed Lines %
service/frontend/api/handler.go 2 62.07%
service/matching/taskListManager.go 2 80.65%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/frontend/wrappers/metered/metered.go 9 63.18%
service/history/execution/mutable_state_task_refresher.go 14 61.39%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018f0e15-3db2-4319-8f9e-70f56acfdbef: 0.004%
Covered Lines: 99132
Relevant Lines: 146462

💛 - Coveralls

@neil-xie neil-xie enabled auto-merge (squash) April 24, 2024 03:36
@neil-xie neil-xie merged commit 5052d08 into cadence-workflow:master Apr 24, 2024
20 checks passed
@neil-xie neil-xie deleted the cdnc_8648 branch April 24, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants