Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish multiple platform docker image when release server #5962

Merged
merged 1 commit into from
May 1, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented May 1, 2024

What changed?
Currently we only support linux/amd64, this is to support linux/arm64
Reference doc: Multi-platform image with GitHub Actions

Why?

How did you test it?
Don't know how can I test this locally, but followed official doc setting up

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f3530-cc75-4db3-8ac7-6ff1d00ec122

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 77 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.02%) to 68.117%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/frontend/api/handler.go 2 62.07%
service/matching/matcher.go 2 91.41%
common/membership/hashring.go 2 84.69%
service/history/queue/timer_queue_processor_base.go 3 77.66%
common/types/history.go 4 45.35%
service/history/engine/engineimpl/historyEngine.go 4 68.85%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/matching/taskListManager.go 4 80.65%
Totals Coverage Status
Change from base Build 018f3404-83c4-4193-8299-780ef8ceaa38: -0.02%
Covered Lines: 100017
Relevant Lines: 146831

💛 - Coveralls

@neil-xie neil-xie merged commit 03d54cf into cadence-workflow:master May 1, 2024
18 checks passed
@neil-xie neil-xie deleted the cdnc_8478 branch May 1, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants