Add metric for async request payload size #5965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| @@ -1771,6 +1771,7 @@ func (wh *WorkflowHandler) StartWorkflowExecutionAsync( | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to encode StartWorkflowExecutionAsyncRequest: %v", err) | |||
| } | |||
| scope.RecordTimer(metrics.AsyncRequestPayloadSize, time.Duration(len(payload))) | |||
There was a problem hiding this comment.
do we have the method-name dimension on this scope? e.g. startworkflowexecution
taylanisikdemir
approved these changes
May 2, 2024
shijiesheng
reviewed
May 2, 2024
| @@ -2178,6 +2178,8 @@ const ( | |||
|
|
|||
| HashringViewIdentifier | |||
|
|
|||
| AsyncRequestPayloadSize | |||
There was a problem hiding this comment.
nit: move to the correct order although the ordering is already broken
ArchivalConfigFailures
ActiveClusterGauge
AsyncRequestPayloadSize
There was a problem hiding this comment.
It's not following an alphabetical order. The order is by functionality.
shijiesheng
approved these changes
May 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018f3a66-fee4-4c5b-b726-da63d4cfff38Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add metric for async request payload size
Why?
improve observability
How did you test it?
Potential risks
Release notes
Documentation Changes