Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests to history_events.go. #5988

Merged
merged 3 commits into from
May 8, 2024

Conversation

agautam478
Copy link
Contributor

What changed?

  • Covered all the branches and methods. The coverage should be 90% +

Why?
Code coevrage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 changed the title Added tests to history_events.go/ Added tests to history_events.go. May 8, 2024
@agautam478 agautam478 enabled auto-merge (squash) May 8, 2024 18:52
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.95%. Comparing base (cb79fcc) to head (74341ea).
Report is 2 commits behind head on master.

Additional details and impacted files

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb79fcc...74341ea. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f5980-bab2-4480-a8ea-58a80a8e70c9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 74 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.02%) to 68.483%

Files with Coverage Reduction New Missed Lines %
common/cache/lru.go 2 92.89%
common/task/fifo_task_scheduler.go 2 87.63%
service/matching/taskListManager.go 2 80.65%
common/membership/hashring.go 2 84.69%
common/persistence/historyManager.go 2 66.67%
service/history/task/transfer_standby_task_executor.go 3 87.45%
service/history/task/task.go 3 84.81%
common/persistence/statsComputer.go 3 96.07%
service/history/task/fetcher.go 4 85.05%
common/task/weighted_round_robin_task_scheduler.go 6 87.06%
Totals Coverage Status
Change from base Build 018f5920-e167-45cd-8901-b0a5fa3bbbfc: -0.02%
Covered Lines: 100589
Relevant Lines: 146881

💛 - Coveralls

@agautam478 agautam478 merged commit 0107705 into cadence-workflow:master May 8, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request May 8, 2024
* Added rest of the history_event.go tests

* Updated the history_events/go tests

* Updated the history_events/go tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants