Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage exclusions #5999

Merged

Conversation

taylanisikdemir
Copy link
Member

What changed?
Excluded service setup files (covered by integration tests only), mock files and other files that only contain type/interface definitions.

Why?
Accurate coverage reporting by excluding non-unit-testable files.

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) May 9, 2024 17:25
@taylanisikdemir taylanisikdemir merged commit 82e3b9c into cadence-workflow:master May 9, 2024
17 of 18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f5e5b-8b2a-497b-84bc-f6577587c6f4

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 68.84%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/fifo_task_scheduler.go 2 87.63%
service/history/queue/transfer_queue_processor.go 2 57.05%
service/matching/taskListManager.go 2 80.65%
service/matching/matcher.go 2 90.72%
Totals Coverage Status
Change from base Build 018f5e29-6cec-46f6-bd34-0915c47e607f: 0.04%
Covered Lines: 101134
Relevant Lines: 146912

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants