Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional unit tests testing history handler #6001

Merged
merged 1 commit into from
May 9, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented May 9, 2024

What changed?
Add unit tests for history handler

Why?
Improve test coverage

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.07%. Comparing base (b4a1f04) to head (f2ee9d7).
Report is 2 commits behind head on master.

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a1f04...f2ee9d7. Read the comment docs.

@timl3136 timl3136 enabled auto-merge (squash) May 9, 2024 22:55
@timl3136 timl3136 merged commit 9532fa3 into cadence-workflow:master May 9, 2024
19 of 20 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f5f90-8e60-435b-8a24-c47a85b01ec7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 75 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.08%) to 68.894%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/membership/hashring.go 2 84.69%
common/persistence/statsComputer.go 3 96.79%
common/task/fifo_task_scheduler.go 4 83.51%
service/frontend/api/handler.go 4 62.2%
service/history/engine/engineimpl/poll_mutable_state.go 9 74.16%
service/history/replication/task_processor.go 52 78.81%
Totals Coverage Status
Change from base Build 018f5e8f-a247-406e-9920-f997ba145d18: 0.08%
Covered Lines: 101213
Relevant Lines: 146912

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants