Persistence support for replication state for execution #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for workflow mutable state to create/read/update replication state for an execution. Suport for transfer task creation for Replication Task.
wxing1292
reviewed
Mar 10, 2018
common/persistence/dataInterfaces.go
Outdated
| @@ -164,6 +165,15 @@ type ( | |||
| ClientImpl string | |||
| } | |||
|
|
|||
| // ReplicationState represents | |||
wxing1292
reviewed
Mar 10, 2018
| @@ -0,0 +1,22 @@ | |||
| -- Replication information for each cluster | |||
There was a problem hiding this comment.
plz change the version from 0.5 to 0.6
wxing1292
reviewed
Mar 10, 2018
schema/cadence/schema.cql
Outdated
| schedule_id bigint, | ||
| first_event_id bigint, |
There was a problem hiding this comment.
could you add some description here?
wxing1292
reviewed
Mar 10, 2018
common/persistence/dataInterfaces.go
Outdated
| // ReplicationTask is the transfer task created for shipping history replication events to other clusters | ||
| ReplicationTask struct { | ||
| TaskID int64 | ||
| DomainID string |
There was a problem hiding this comment.
is this DomainID necessary?
There was a problem hiding this comment.
You are right. Replication task is always going to be for the same domain. Removed.
wxing1292
approved these changes
Mar 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for workflow mutable state to create/read/update
replication state for an execution.
Support for transfer task creation for Replication Task.
Added unit test for replication state for execution