Adding more tests to shard/context.go

[dkrotx]

Tests for couple of more functions in context.go

code-coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (fb4bfce) to head (2d60232).
Report is 1 commits behind head on master.

Additional details and impacted files

see 8 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4bfce...2d60232. Read the comment docs.

[coveralls]

Pull Request Test Coverage Report for Build 018fa61a-80af-43aa-bd2e-7170bb094d50

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 141 unchanged lines in 13 files lost coverage.
• Overall coverage decreased (-0.04%) to 69.315%

---

Files with Coverage Reduction	New Missed Lines	%
service/history/task/transfer_standby_task_executor.go	2	87.65%
service/matching/tasklist/db.go	2	73.23%
service/matching/tasklist/task_list_manager.go	2	76.09%
service/frontend/api/handler.go	2	62.2%
service/history/replication/task_processor.go	2	81.25%
service/matching/tasklist/matcher.go	2	88.66%
common/log/tag/tags.go	3	50.46%
common/archiver/filestore/historyArchiver.go	4	80.95%
common/persistence/nosql/nosql_task_store.go	5	63.97%
service/frontend/wrappers/metered/metered.go	9	63.18%

Totals
Change from base Build 018fa5a0-da9b-4f76-9263-3511c2f681f9:	-0.04%
Covered Lines:	102126
Relevant Lines:	147336

---

💛 - Coveralls

[jakobht]

Added a small comment

[jakobht]

Would it be possible to check something more than just not nil?

[dkrotx]

Ouch. Completely missed your question.
Unfortunately, didn't find any meaningful return value there. resp' content is not really having anything related to test. It's more to check mocks.