Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[execution_manager] Add unit tests for ConflictResolveWorkflowExecution #6076

Conversation

3vilhamster
Copy link
Contributor

What changed?
Added unit tests for ConflictResolveWorkflowExecution.

Why?
Improving unit tests coverage.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fcfa6-57ec-44e8-9c83-8f24a3d2a3c1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.003%) to 69.652%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.33%
service/matching/tasklist/task_list_manager.go 2 76.09%
service/history/execution/mutable_state_util.go 2 78.52%
service/history/queue/timer_queue_processor_base.go 3 77.87%
service/history/task/fetcher.go 3 85.57%
common/types/history.go 4 45.35%
service/history/engine/engineimpl/record_activity_task_started.go 4 68.87%
service/frontend/wrappers/metered/metered.go 4 66.67%
Totals Coverage Status
Change from base Build 018fcf32-23d9-4d7d-a579-94202b6c6918: -0.003%
Covered Lines: 102993
Relevant Lines: 147868

💛 - Coveralls

@3vilhamster 3vilhamster merged commit 387f827 into cadence-workflow:master Jun 3, 2024
18 checks passed
@3vilhamster 3vilhamster deleted the execution-manager-ConflictResolveWorkflowExecution branch June 3, 2024 08:20
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants