Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant parameter from CreateTasks flow #6077

Merged
merged 1 commit into from
May 31, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented May 31, 2024

What changed?
Remove redundant parameter from CreateTasks flow

Why?
persistence.TaskInfo has workflowID and runID fields, which makes Execution parameter redundant.

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 68.22%. Comparing base (dd54cd0) to head (d1869a3).
Report is 4 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
common/persistence/data_manager_interfaces.go 95.50% <ø> (ø)
common/persistence/data_store_interfaces.go 100.00% <ø> (ø)
service/matching/handler/engine.go 56.47% <ø> (-0.14%) ⬇️
service/matching/tasklist/task_writer.go 77.44% <100.00%> (-0.34%) ⬇️
service/matching/tasklist/task_list_manager.go 63.70% <50.00%> (ø)
service/matching/tasklist/task_reader.go 73.80% <0.00%> (+0.92%) ⬆️
common/persistence/nosql/nosql_task_store.go 71.06% <0.00%> (ø)
common/persistence/taskManager.go 0.00% <0.00%> (ø)

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd54cd0...d1869a3. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fcfdb-0ea2-4e72-985c-12357d6a7098

Details

  • 10 of 14 (71.43%) changed or added relevant lines in 7 files are covered.
  • 1231 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-0.03%) to 69.623%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/matching/tasklist/task_list_manager.go 1 2 50.0%
service/matching/tasklist/task_reader.go 0 1 0.0%
common/persistence/persistence-tests/persistenceTestBase.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.33%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
common/task/fifo_task_scheduler.go 2 80.41%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/visibility_single_manager.go 2 99.33%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/queue/timer_queue_processor_base.go 3 77.87%
common/persistence/wrappers/errorinjectors/utils.go 3 93.7%
Totals Coverage Status
Change from base Build 018fcf32-23d9-4d7d-a579-94202b6c6918: -0.03%
Covered Lines: 102829
Relevant Lines: 147693

💛 - Coveralls

@Shaddoll Shaddoll merged commit eb076b2 into cadence-workflow:master May 31, 2024
20 checks passed
@Shaddoll Shaddoll deleted the task branch May 31, 2024 22:37
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants