-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for poller package #6110
Conversation
// poller ID -> pollerInfo | ||
// pollers map[pollerID]pollerInfo | ||
history cache.Cache | ||
History struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Less indentation is preferred so I don't favor grouping structs under a type( ... )
section
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018fea05-88b4-4991-90c9-851efe00e9f8Details
💛 - Coveralls |
What changed?
Add unit tests for poller package
Why?
improve coverage
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes