Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for poller package #6110

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Jun 5, 2024

What changed?
Add unit tests for poller package

Why?
improve coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

// poller ID -> pollerInfo
// pollers map[pollerID]pollerInfo
history cache.Cache
History struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Less indentation is preferred so I don't favor grouping structs under a type( ... ) section

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.39%. Comparing base (4326afb) to head (c751586).
Report is 6 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
service/matching/poller/history.go 100.00% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4326afb...c751586. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 018fea05-88b4-4991-90c9-851efe00e9f8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 111 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.05%) to 70.687%

Files with Coverage Reduction New Missed Lines %
service/matching/tasklist/db.go 2 73.23%
common/peerprovider/ringpopprovider/config.go 2 81.58%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.46%
common/task/fifo_task_scheduler.go 3 84.54%
bench/lib/client.go 4 0.0%
service/matching/tasklist/task_reader.go 11 75.33%
Totals Coverage Status
Change from base Build 018fe9e9-5b1b-4b55-a4a1-8f985d11d2a5: -0.05%
Covered Lines: 105289
Relevant Lines: 148951

💛 - Coveralls

@Shaddoll Shaddoll merged commit ce92cd8 into cadence-workflow:master Jun 5, 2024
20 checks passed
@Shaddoll Shaddoll deleted the poller branch June 5, 2024 22:28
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants