Add more metrics to async task dispatch #6202
Conversation
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| return nil | ||
| case <-ctx.Done(): | ||
| return fmt.Errorf("context done when trying to forward local task: %w", ctx.Err()) | ||
| default: | ||
| } | ||
|
|
||
| attempt := 0 |
There was a problem hiding this comment.
My memory is slightly hazy here, but I'd be careful interpreting this value as the actual number of retries per task, if I recall correctly this times out (in pathological cases) and then ends up looping from dispatchSingleTaskFromBufferWithRetries or above, I dont' recall exactly, so the actual number of attempts per task may be much higher.
I don't think its bad to include this metric like this, but I just think it may only capture part of the issue, and possibly adding an attempt/timer higher up might be worthwhile to more fully capture the wait time (maybe dispatchSingleTaskFromBufferWithRetries)?
What changed?
Add more metrics to async task dispatch
Why?
Improve observability
How did you test it?
manual tests
Potential risks
Release notes
Documentation Changes