Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug es-analyzer: workable workflow type counts #6206

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Aug 1, 2024

What changed?

  1. Fixed a bug when advancedVisibility mode is in migration: it will cause a nil pointer for esconfig
    -handle index name and table name to avoid nil pointer

  2. Deleted Offset clause because we don't need pagination.

Why?
debug es-analyzer

How did you test it?
unit test
manual test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.93%. Comparing base (06e5a6d) to head (f7b0573).

Additional details and impacted files
Files Coverage Δ
service/worker/esanalyzer/analyzer.go 44.82% <100.00%> (+6.36%) ⬆️
...rker/esanalyzer/domainWorkflowTypeCountWorkflow.go 82.92% <ø> (-0.11%) ⬇️
service/worker/esanalyzer/workflow.go 89.82% <ø> (-0.09%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e5a6d...f7b0573. Read the comment docs.

@bowenxia bowenxia changed the title handle index name and table name to avoid nil pointer Debug es-analyzer Aug 2, 2024
@bowenxia bowenxia changed the title Debug es-analyzer Debug es-analyzer: workable workflow type counts Aug 2, 2024
@bowenxia bowenxia merged commit a56d386 into master Aug 2, 2024
21 checks passed
@bowenxia bowenxia deleted the xbowen_esAnalyzer_debug00 branch August 2, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants