Add metrics for tasks already started in matching #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? Added metrics to PollForDecisionTask and PollForActivityTask to track when the task being polled has already started and therefore discarded. Why? This metric will give visibility to the accumulation of stale tasks in matching and will serve as a baseline for future work on that part. How did you test it? Potential risks Release notes Documentation Changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
common/metrics/defs.go
Outdated
| @@ -3227,6 +3229,8 @@ var MetricDefs = map[ServiceIdx]map[int]metricDefinition{ | |||
| PollLocalMatchLatencyPerTaskList: {metricName: "poll_local_match_latency_per_tl", metricRollupName: "poll_local_match_latency", metricType: Timer}, | |||
| PollForwardMatchLatencyPerTaskList: {metricName: "poll_forward_match_latency_per_tl", metricRollupName: "poll_forward_match_latency", metricType: Timer}, | |||
| PollLocalMatchAfterForwardFailedLatencyPerTaskList: {metricName: "poll_local_match_after_forward_failed_latency_per_tl", metricRollupName: "poll_local_match_after_forward_failed_latency", metricType: Timer}, | |||
| PollDecisionTaskAlreadyStartedCounter: {metricName: "poll_decision_task_already_started", metricType: Counter}, | |||
There was a problem hiding this comment.
do you mind changing this to be:
{ metricName: "poll_decision_task_already_started_per_tl", metricType: Counter},
fimanishi
requested review from
Shaddoll,
neil-xie,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
davidporter-id-au
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added metrics to PollForDecisionTask and PollForActivityTask to track when the task being polled has already started and therefore discarded.
Why?
This metric will give visibility to the accumulation of stale tasks in matching and will serve as a baseline for future work on that part.
How did you test it?
Potential risks
Release notes
Documentation Changes