Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new metrics to detect misconfigured tasklist partition #6251

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add new metrics to detect misconfigured tasklist partition #6251

merged 1 commit into from
Aug 26, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Add new metrics to detect misconfigured tasklist partition

Why?
Misconfigured tasklist partition can decrease sync match rate for task matching and increase schedule-to-start latency for customers when their load is high.

How did you test it?

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll force-pushed the partition branch 2 times, most recently from f0cf00f to 414202f Compare August 23, 2024 22:14
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.98%. Comparing base (c0cd4c5) to head (937acd7).
Report is 2 commits behind head on master.

Files Patch % Lines
service/matching/tasklist/task_list_manager.go 60.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
Files Coverage Δ
service/matching/poller/history.go 100.00% <100.00%> (ø)
service/matching/tasklist/task_list_manager.go 68.25% <60.00%> (+0.85%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0cd4c5...937acd7. Read the comment docs.

davidporter-id-au
davidporter-id-au approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this will be helpful

@Shaddoll Shaddoll merged commit 8d487ef into cadence-workflow:master Aug 26, 2024
19 of 20 checks passed
@Shaddoll Shaddoll deleted the partition branch August 26, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekj720 abhishekj720 abhishekj720 approved these changes

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@Groxx Groxx Awaiting requested review from Groxx

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaddoll @davidporter-id-au @abhishekj720