bugfix: when multiple activity got timeouted, there will be at most o… #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne being actually deleted in Cassandra
samarabbas
approved these changes
Apr 4, 2018
nathanboktae
pushed a commit
that referenced
this pull request
Apr 12, 2018
…ne being actually deleted in Cassandra (#655)
nathanboktae
added a commit
that referenced
this pull request
Apr 12, 2018
* bump cadence-web to 1.1.1 * bugfix: when multiple activity got timeouted, there will be at most one being actually deleted in Cassandra (#655) * Bugfix: Recreate activity heartbeat timeout after first timer fire (#658) When the heartbeat timeout is created for the very first time it uses StartEventID as the dedupe event ID. But it is possible that it is a buffered event and no ID is specified when the timer task is created. This trips the recreation logic from recreating the timer. This change instead relies on the schedule ID for the event for dedupe event ID of the heartbeat timer. * Bump cadence web to 1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ne being actually deleted in Cassandra