add jitter to timer / transfer / replication queue sanity scan #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancexu
suggested changes
Jun 19, 2018
service/history/queueAckMgr_test.go
Outdated
| @@ -140,7 +140,10 @@ func (s *queueAckMgrSuite) SetupTest() { | |||
| } | |||
| s.mockShard.config.ShardUpdateMinInterval = dynamicconfig.GetDurationPropertyFn(0 * time.Second) | |||
|
|
|||
| s.queueAckMgr = newQueueAckMgr(s.mockShard, &QueueProcessorOptions{UpdateShardTaskCount: 1, MetricScope: metrics.ReplicatorQueueProcessorScope}, s.mockProcessor, 0, s.logger) | |||
| s.queueAckMgr = newQueueAckMgr(s.mockShard, &QueueProcessorOptions{ | |||
| UpdateShardTaskCount: func(opts ...dynamicconfig.FilterOption) int { return 1 }, | |||
There was a problem hiding this comment.
Could use dynamicconfig.GetIntPropertyFn() which is mock for tests.
service/history/queueAckMgr_test.go
Outdated
| @@ -346,7 +349,10 @@ func (s *queueFailoverAckMgrSuite) SetupTest() { | |||
| } | |||
| s.mockShard.config.ShardUpdateMinInterval = dynamicconfig.GetDurationPropertyFn(0 * time.Second) | |||
|
|
|||
| s.queueFailoverAckMgr = newQueueFailoverAckMgr(s.mockShard, &QueueProcessorOptions{UpdateShardTaskCount: 1, MetricScope: metrics.ReplicatorQueueProcessorScope}, s.mockProcessor, 0, s.logger) | |||
| s.queueFailoverAckMgr = newQueueFailoverAckMgr(s.mockShard, &QueueProcessorOptions{ | |||
| UpdateShardTaskCount: func(opts ...dynamicconfig.FilterOption) int { return 1 }, | |||
There was a problem hiding this comment.
Could use dynamicconfig.GetIntPropertyFn()
| @@ -177,6 +177,8 @@ const ( | |||
| TimerProcessorCompleteTimerInterval | |||
| // TimerProcessorMaxPollInterval is max poll interval for timer processor | |||
| TimerProcessorMaxPollInterval | |||
| // TimerProcessorMaxPollIntervalJitterCoefficient is the max poll interval jitter coefficient | |||
| TimerProcessorMaxPollIntervalJitterCoefficient | |||
There was a problem hiding this comment.
There new added keys also need to updated in keys map in this file.
vancexu
approved these changes
Jun 19, 2018
samarabbas
reviewed
Jun 20, 2018
| @@ -292,7 +296,10 @@ continueProcessor: | |||
| // Timer Fired. | |||
| case <-pollTimer.C: | |||
| // forced timer scan | |||
| pollTimer.Reset(t.config.TimerProcessorMaxPollInterval()) | |||
| pollTimer.Reset(jitter.JitDuration( | |||
There was a problem hiding this comment.
Can we keep track of the last updated time and skip force timer scan if it is less then max poll interval?
samarabbas
reviewed
Jun 20, 2018
service/history/queueProcessor.go
Outdated
| @@ -156,10 +160,10 @@ processorPumpLoop: | |||
| p.processBatch(tasksCh) | |||
| case <-pollTimer.C: | |||
| p.processBatch(tasksCh) | |||
| pollTimer.Reset(p.options.MaxPollInterval) | |||
| pollTimer.Reset(jitter.JitDuration(p.options.MaxPollInterval(), p.options.MaxPollIntervalJitterCoefficient())) | |||
There was a problem hiding this comment.
I think we want same logic to skip the forced scan if already performed recently.
samarabbas
approved these changes
Jun 20, 2018
added 2 commits
June 19, 2018 22:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #856