[Docs] Nest component routes, and set initiallyOpen for Nav List item… #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s based on current route Resolves #3023.
| @@ -92,39 +92,54 @@ const AppRoutes = ( | |||
| <Route path="auto-complete" component={AutoCompletePage} /> | |||
| <Route path="avatar" component={AvatarPage} /> | |||
| <Route path="badge" component={BadgePage} /> | |||
| <Redirect from="buttons" to="/components/buttons/flat-button" /> | |||
| <Route path="buttons"> | |||
There was a problem hiding this comment.
Can we keep the url flat for the doc section?
I don't think that it's a good idea to nest it, as we don't nest our source folder.
There was a problem hiding this comment.
It looks like it's for the initiallyOpen. I would rather fix this at the List components level.
|
@oliviertassinari I did ask if there were any objections. 😒 |
|
Yes, indeed. Sorry I have over looked the implications. You don't necessarily have to close the PR. People may argue the opposite. |
|
Well, I do agree that fixing it in the list HOC would be preferable, but having the routes matching the menu nesting seemed a simple alternative for now. I can see your point though - it would just have been nice to have it sooner. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s based on current route
Resolves #3023.