Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration tests failing #54

Merged
merged 3 commits into from
Nov 12, 2022
Merged

fix: integration tests failing #54

merged 3 commits into from
Nov 12, 2022

Conversation

cameri
Copy link
Owner

@cameri cameri commented Nov 12, 2022

Description

  1. Set PORT environment variable so integration tests can connect to the relay under test

Related Issue

#3

Motivation and Context

  1. SERVER_PORT was renamed to PORT which caused integration tests to fail. Unsure why CI did not catch this.

How Has This Been Tested?

  1. Ran integration and coverage tests locally.

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri self-assigned this Nov 12, 2022
@cameri cameri temporarily deployed to test November 12, 2022 01:30 Inactive
@coveralls
Copy link
Collaborator

coveralls commented Nov 12, 2022

Pull Request Test Coverage Report for Build 3449073182

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.4%) to 88.667%

Totals Coverage Status
Change from base Build 3447595521: 4.4%
Covered Lines: 724
Relevant Lines: 807

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cameri cameri merged commit fb9de12 into main Nov 12, 2022
@cameri cameri deleted the fix/intg_tests branch November 12, 2022 02:00
@github-actions
Copy link

🎉 This PR is included in version 1.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants