Skip to content

Commit

Permalink
build: do not include netty in zeebe bom
Browse files Browse the repository at this point in the history
Due to a bug in netty, some projects that inlude zeebe-bom in their dependency encountered build failure. It is not clear why we added netty in zeebe bom. Ideally third party dependencies should not be in the project bom.

(cherry picked from commit 862cf6e)
  • Loading branch information
deepthidevaki committed Oct 7, 2021
1 parent d0c41b4 commit f81b6fe
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
11 changes: 1 addition & 10 deletions bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<artifactId>camunda-release-parent</artifactId>
<version>3.8.1</version>
<!-- do not remove empty tag - http://jira.codehaus.org/browse/MNG-4687 -->
<relativePath />
<relativePath/>
</parent>

<properties>
Expand All @@ -26,8 +26,6 @@
</nexus.release.repository>
<nexus.sonatype.url>https://s01.oss.sonatype.org</nexus.sonatype.url>

<version.netty>4.1.68.Final</version.netty>

<version.java>11</version.java>
<plugin.version.javadoc>3.3.1</plugin.version.javadoc>
</properties>
Expand Down Expand Up @@ -221,13 +219,6 @@
<version>${project.version}</version>
</dependency>

<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
<version>${version.netty}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>

Expand Down
9 changes: 9 additions & 0 deletions parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
<version.model>7.7.0</version.model>
<version.msgpack>0.9.0</version.msgpack>
<version.netty-tcnative>2.0.43.Final</version.netty-tcnative>
<version.netty>4.1.68.Final</version.netty>
<version.objenesis>3.2</version.objenesis>
<version.prometheus>0.12.0</version.prometheus>
<version.protobuf>3.18.0</version.protobuf>
Expand Down Expand Up @@ -425,6 +426,14 @@
<version>${version.netty-tcnative}</version>
</dependency>

<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
<version>${version.netty}</version>
<type>pom</type>
<scope>import</scope>
</dependency>

<dependency>
<groupId>org.elasticsearch</groupId>
<artifactId>elasticsearch-x-content</artifactId>
Expand Down

0 comments on commit f81b6fe

Please sign in to comment.