Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyzeebe 3.0.0 #136

Closed
JonatanMartens opened this issue Mar 6, 2021 · 4 comments · Fixed by #172
Closed

Pyzeebe 3.0.0 #136

JonatanMartens opened this issue Mar 6, 2021 · 4 comments · Fixed by #172
Milestone

Comments

@JonatanMartens
Copy link
Collaborator

JonatanMartens commented Mar 6, 2021

Zeebe 1.0.0 is currently in alpha. This release will contain some breaking changes (see here). I believe this to be an opportunity to make some other breaking changes:

Please feel free to add any suggestions for other potential changes here!

@kbakk
Copy link
Collaborator

kbakk commented Mar 8, 2021

This sounds like it will introduce a few breaking changes for the users of Pyzeebe - which of course is fair, we're working with a pre-1.0 product so that is to be expected. We should then have a migration guide to ease the "pain".

I have a few suggestions that comes to mind:

I would like to try to do a PR on #81 and #103, and can help with the migration guide as well - do we have a due date on when this needs to be in place?

  • Asyncio support

This one is a large undertaking, but I can see how introducing this can enable more users to use Pyzeebe (e.g. wanting to migrate from Kafka based Async workers, without asyncio support that would mean a large rewrite).

One concern here is how to support both the threaded workers and the async workers. I can imagine we'll have the job handlers remain threaded, and use asyncio within each thread?

We should open an issue on this to discuss this further. I'm not sure 3.0 should depend on this though (we could plan for it, and introduce it in 3.1).

It would also be nice if we could create pre-releases from the develop branch.

@kbakk
Copy link
Collaborator

kbakk commented Mar 13, 2021

Can we create a milestone for this?

@JonatanMartens JonatanMartens added this to the Pyzeebe 3.0.0 milestone Mar 15, 2021
@JonatanMartens
Copy link
Collaborator Author

Docs for the 3.0.0 pre-release can be found here: https://pyzeebe.readthedocs.io/en/pre-release-3.0.0/

@JonatanMartens JonatanMartens linked a pull request May 23, 2021 that will close this issue
2 tasks
@JonatanMartens
Copy link
Collaborator Author

finally released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants