Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Job safe #179

Closed
JonatanMartens opened this issue Jun 30, 2021 · 0 comments · Fixed by #453
Closed

Make Job safe #179

JonatanMartens opened this issue Jun 30, 2021 · 0 comments · Fixed by #453
Labels
3.0.0 Will be released in Zeebe 3.0.0 4.0.0 Will be released in Zeebe 4.0.0 breaking change

Comments

@JonatanMartens
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

In #176 we added functionality to access the job and its parameters inside of a task. This gives the task the ability to change certain parameters of the job (key for example) which could cause pyzeebe to send a wrong request to the zeebe gateway.

Describe the solution you'd like

Split the functionality of the Job class into two classes:

1 Job: would contain access to the same parameters as the current class, but without the ZeebeAdapter and the ability to send the job status to zeebe. It would also be read-only (like dataclasses's frozen).

2 JobController: would inherit from Job but add the missing capabilities from the previous Job class (set_success_status, set_failure_status and set_error_status)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0.0 Will be released in Zeebe 3.0.0 4.0.0 Will be released in Zeebe 4.0.0 breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants