Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change grpc options (channel_arguments) from dict to tuple #482

Closed
felicijus opened this issue Sep 18, 2024 · 0 comments · Fixed by #483
Closed

Change grpc options (channel_arguments) from dict to tuple #482

felicijus opened this issue Sep 18, 2024 · 0 comments · Fixed by #483
Labels
4.0.0 Will be released in Zeebe 4.0.0

Comments

@felicijus
Copy link
Contributor

felicijus commented Sep 18, 2024

Is your feature request related to a problem? Please describe.

When changing between librarys we should not expect users to define the channel options differently than the official grpc package itself.

Describe the solution you'd like

We should rewrite that to just use tuples as grpc itself does.

e.g. Link to the Documentation suggests tuple[tuple[...]] (('grpc.so_reuseport', 0),) but we expect Dict[str, Any].

channel_options (Optional[Dict], optional): GRPC channel options. See https://grpc.github.io/grpc/python/glossary.html

Additional context

https://grpc.github.io/grpc/python/glossary.html

I think it (changing options from dict to tuple) should be in another PR.

Originally posted by @dimastbk in #468 (comment)

@dimastbk dimastbk added the 4.0.0 Will be released in Zeebe 4.0.0 label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0.0 Will be released in Zeebe 4.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants