Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change channel parameter hostname, port to grpc_adress #499

Conversation

felicijus
Copy link
Contributor

@felicijus felicijus commented Oct 1, 2024

Simplify channel creation parameters to reflect Camunda exported .env file/variables. This means a combinde variable for hostname and port.

Changes

  • create_insecure_channel - grpc_adress parameter instead of hostname, port
  • create_secure_channel - grpc_adress parameter instead of hostname, port
  • utils ro reflect changes

API Updates

New Features (required)

Use one parameter grpc_address to provide Zeebe Address.

Deprecations (required)

Usage of hostname and port for channel creation.

Enhancements (optional)

None

Checklist

  • Unit tests
  • Documentation
  • Examples

References (optional)

https://javadoc.io/doc/io.camunda/zeebe-client-java/latest/io/camunda/zeebe/client/ZeebeClientBuilder.html

Connects #468
Resolves #497

@coveralls
Copy link

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11127508903

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 96.615%

Totals Coverage Status
Change from base Build 11100841235: -0.007%
Covered Lines: 999
Relevant Lines: 1034

💛 - Coveralls

@felicijus felicijus marked this pull request as ready for review October 1, 2024 14:33
@dimastbk dimastbk merged commit 729449f into camunda-community-hub:master Oct 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change channel parameter hostname, port to grpc_address
3 participants