Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create_camunda_cloud_channel #514

Conversation

felicijus
Copy link
Contributor

@felicijus felicijus commented Oct 10, 2024

Fix create_camunda_cloud_channel, current and deprecated functions.

Changes

  1. audience should be static Camunda Docs
    audience="zeebe.camunda.io
  2. scope should either be None (Optional parameter), because setting it to the cluster_id also works. Maybe relevant for enterprise user with custom scope configs...
  3. leeway and expire_in i don't really know if there is need for customization. Would not hurt to keep I guess.

#510 Is an import error, where the old create_camunda_cloud_channel function was used. (The old function also needs a static audience)

API Updates

New Features (required)

None

Deprecations (required)

pyzeebe.channel.camunda_cloud_channel.create_camunda_cloud_channel

Enhancements (optional)

Less default parameters.

Checklist

  • Unit tests
  • Documentation

References (optional)

https://docs.camunda.io/docs/8.5/apis-tools/build-your-own-client/#authentication-via-oauth

Fixes #510

@felicijus
Copy link
Contributor Author

@dimastbk Do we have the option to create Camunda Cloud (SaaS) integration tests ?

@felicijus felicijus marked this pull request as ready for review October 10, 2024 19:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11280788679

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.922%

Totals Coverage Status
Change from base Build 11277676454: 0.0%
Covered Lines: 1102
Relevant Lines: 1137

💛 - Coveralls

@felicijus
Copy link
Contributor Author

Let's wait for #510 to be resolved.
@barthansen

@dimastbk
Copy link
Collaborator

I don't know, I test on trial cluster

@dimastbk dimastbk merged commit 0447086 into camunda-community-hub:master Oct 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0.0rc6 and rc7 generate connection errors
3 participants