Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default concurrent requests to 1 #32

Closed
npepinpe opened this issue Sep 11, 2020 · 0 comments · Fixed by #34
Closed

Reduce default concurrent requests to 1 #32

npepinpe opened this issue Sep 11, 2020 · 0 comments · Fixed by #34
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@npepinpe
Copy link
Collaborator

By default, the exporter uses an idempotent producer with "infinite" retries and delivery time out. However, it also configures a max of 3 concurrent requests, which may result (due to retries) in some batches being delivered out of order. To avoid this, the default should lower it to a single request, which anyway should be fine for most use cases.

It may not even be advisable to expose the configuration option as we currently do, and leave it up to advanced users to configure it via the free-form producer properties if they really want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant