Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to set specific images via ZeebeClusterBuilder #143

Merged

Conversation

aivinog1
Copy link
Contributor

Description

I've added the convenience methods to set a docker image for the Zeebe container in the cluster.

Related issues

closes #139

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing
  • Ensure all PR checks are green

@aivinog1
Copy link
Contributor Author

Hey @npepinpe! I see that you are the main contributor to this project, can you start workflows? :)

Copy link
Collaborator

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alexey, thanks for the PR! This seems like a reasonable feature - it's a little cumbersome having to iterate over brokers/gateways after building the cluster to set these properties. I think we may want to take a different approach to customizing them eventually - but as this is an experimental API, there's no reason for us not to play around with different approaches.

One small comment on the tests: I found that describing the assertions help a lot with readability, especially for others. You'll notice almost all assertions have an as method which gives more context. It's important when writing tests not only to ensure they're correct, but also that when they fail, we provide as much context as possible so the person looking at it (who may not have written the test initially) knows what needs to be fixed.

@aivinog1
Copy link
Contributor Author

aivinog1 commented Jun 1, 2021

Hey @npepinpe. Can you take another look?

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@npepinpe npepinpe merged commit 6c80784 into camunda-community-hub:master Sep 7, 2021
@aivinog1 aivinog1 deleted the 139-set-image-name-in-builder branch September 7, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set the test image name in the Zeebe cluster builder
3 participants