Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secrets Rule and Disable #133

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Fix secrets Rule and Disable #133

merged 5 commits into from
Sep 8, 2023

Conversation

philippfromme
Copy link
Collaborator

@philippfromme philippfromme commented Sep 8, 2023 •
edited
Loading

  • secrets rule reports warning instead of error
  • secrets rule is disabled (for now)

Closes #132

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 8, 2023
@philippfromme philippfromme requested a review from barmac September 8, 2023 11:28
@merge-me merge-me bot merged commit 4de013b into main Sep 8, 2023
2 checks passed
@merge-me merge-me bot deleted the secrets-error-to-warn branch September 8, 2023 12:23
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 8, 2023
This was referenced Sep 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

secrets Rule Should Report Warning Instead of Error
2 participants
@philippfromme @barmac