feat: support execution listeners #168
Conversation
barmac
force-pushed
the
execution-listeners
branch
3 times, most recently
from
5513a78 to
29b42cb
Compare
bpmn-io-tasks
bot
added
needs review
barmac
requested review from
a team,
philippfromme and
jarekdanielak
and removed request for
a team
barmac
force-pushed
the
execution-listeners
branch
from
29b42cb to
3841463
Compare
| module.exports = skipInNonExecutableProcess(function() { | ||
| function check(node, reporter) { | ||
|
|
||
| console.log(node); |
There was a problem hiding this comment.
We probably don't want that.
| return; | ||
| } | ||
|
|
||
| const errors = hasDuplicatedExecutionListeners(executionListeners, node); |
There was a problem hiding this comment.
Have we considered using the existing helper used by a similar rule (https://github.com/camunda/bpmnlint-plugin-camunda-compat/blob/main/rules/camunda-cloud/duplicate-task-headers.js#L28)?
There was a problem hiding this comment.
I guess it's because duplication requires two duplicate properties instead of just one. We could still adjust the helper to allow multiple properties.
There was a problem hiding this comment.
I have considered this and decided against it due to the adjustment needed. If we have more cases like this, we may abstract it away, but right now I'd consider it YAGNI.
There was a problem hiding this comment.
I'm not a huge fan of using ERROR_TYPES.PROPERTY_VALUE_DUPLICATED and then duplicatedProperty: 'type' since it doesn't mention the event type at all. We should probably have a separate type PROPERTY_VALUES_DUPLICATED and include all the data necessary to create a custom error message.
There was a problem hiding this comment.
I'd just add a hasDuplicatedPropertiesValues helper that encapsulates the logic so the rule simply calls hasDuplicatedPropertiesValues(taskHeaders, 'listeners', [ 'eventType', 'type' ], node). 🤔
There was a problem hiding this comment.
@philippfromme please have a look now.
Related to camunda/camunda-modeler#3951 feat: add `no-duplicate-execution-listeners` rule feat: add `no-execution-listeners` rule feat: add `execution-listener` rule
barmac
force-pushed
the
execution-listeners
branch
from
897e806 to
1c0aa1f
Compare
Related to camunda/camunda-modeler#3951
Contains:
no-duplicate-execution-listenersrule - to prevent duplicates rejected by the engineno-execution-listenersrule - to prevent usage with unsupported engine versionexecution-listenerrule - to ensure correct configuration