-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate important content from Optimize 8 documentation to Optimize 7 3.14 #4780
Comments
What content do we want to migrate?
What happened so far?
|
I don't intend to squash the commits in the PRs. It will be helpful to have the history on the branches. We would have a similar history if the branches had been created through a regular release. |
@psavidis, I did not try out the Python link validator. However, I tested the pages with broken links and found no issues.
|
Hey @mboskamp, I used a small python script locally and was still able to find occurrences across pages so i stopped counting them all one by one. I've approved the pull requests for now since content-wise, the pull requests look good to me. However, the broken links despite not critical still have to be fixed eventually. The sheer size of content that needs migration renders both the review and fixing it difficult and time consuming. To assist this effort, i'd like to recommend the following : a) Since the content looks ok, you can either create a separate task to fix broken links across all the pages using a parent branch which can in the end be merged to the respective branches b) Merge directly, let the CI fail to detect the broken links and fix them in a follow-up. Feel free to decide whatever works for you best. |
After discussing with @psavidis we decided to
|
@psavidis, I merged the 3.14 branch and fixed the seven reported broken links. Please have a look at this follow-up PR for 3.14 and the 3.13 PR. It was possible to cherry-pick the 3.13 commit to 3.12 and 3.11, so no additional review is necessary there in my opinion. |
Review of |
CI looks good on all branches. |
Acceptance Criteria (Required on creation)
The Optimize 3.14 documentation branch is a copy of the 3.8 branch. We need to identify major updates and migrate them on a best-effort basis. We can always iterate and migrate more in the future.
Hints
Links
Breakdown
Pull Requests
The text was updated successfully, but these errors were encountered: