Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate important content from Optimize 8 documentation to Optimize 7 3.14 #4780

Closed
5 tasks done
Tracked by #4716
mboskamp opened this issue Nov 8, 2024 · 8 comments
Closed
5 tasks done
Tracked by #4716
Assignees
Labels
type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue.

Comments

@mboskamp
Copy link
Member

mboskamp commented Nov 8, 2024

Acceptance Criteria (Required on creation)

The Optimize 3.14 documentation branch is a copy of the 3.8 branch. We need to identify major updates and migrate them on a best-effort basis. We can always iterate and migrate more in the future.

Hints

Links

Breakdown

Pull Requests

@mboskamp mboskamp added the type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. label Nov 8, 2024
@mboskamp mboskamp self-assigned this Nov 8, 2024
@mboskamp
Copy link
Member Author

mboskamp commented Nov 13, 2024

What content do we want to migrate?

  • Update/Migration guides
  • Dependency Information
  • Installation guide
  • Features
    • OpenSearch support: This feature has impact on many aspects of the documentation. It's an alternative DB (next to Elasticsearch), so in all places where we talk about Elasticsearch, we need to include OpenSearch or generically talk about "databases".
    • other features?

What happened so far?

@mboskamp
Copy link
Member Author

I don't intend to squash the commits in the PRs. It will be helpful to have the history on the branches. We would have a similar history if the branches had been created through a regular release.

@psavidis psavidis assigned mboskamp and unassigned psavidis Nov 18, 2024
@mboskamp
Copy link
Member Author

@psavidis, I did not try out the Python link validator. However, I tested the pages with broken links and found no issues.
I had to battle with Git a lot to get a clean history. All the hashes are probably different due to history rewrites.
The main changes are:

@mboskamp mboskamp assigned psavidis and unassigned mboskamp Nov 22, 2024
@psavidis
Copy link
Contributor

Hey @mboskamp,

I used a small python script locally and was still able to find occurrences across pages so i stopped counting them all one by one.

I've approved the pull requests for now since content-wise, the pull requests look good to me. However, the broken links despite not critical still have to be fixed eventually.

The sheer size of content that needs migration renders both the review and fixing it difficult and time consuming. To assist this effort, i'd like to recommend the following :

a) Since the content looks ok, you can either create a separate task to fix broken links across all the pages using a parent branch which can in the end be merged to the respective branches

b) Merge directly, let the CI fail to detect the broken links and fix them in a follow-up.

Feel free to decide whatever works for you best.

@psavidis psavidis assigned mboskamp and unassigned psavidis Nov 26, 2024
@mboskamp
Copy link
Member Author

After discussing with @psavidis we decided to

  • merge the PRs as they are right now
  • check if the broken links on stage break are detected by the link checker
  • check if any other links are broken
  • create a follow-up ticket to
    • convert all relative links to use the custom hugo snippet ({{< ref "" >}}, there are about 100 of these)

@mboskamp
Copy link
Member Author

mboskamp commented Dec 2, 2024

@psavidis, I merged the 3.14 branch and fixed the seven reported broken links. Please have a look at this follow-up PR for 3.14 and the 3.13 PR. It was possible to cherry-pick the 3.13 commit to 3.12 and 3.11, so no additional review is necessary there in my opinion.

@mboskamp mboskamp assigned psavidis and unassigned mboskamp Dec 2, 2024
@psavidis
Copy link
Contributor

psavidis commented Dec 2, 2024

Review of 3.14, 3.13 is done. Since the cherry pick is the same for the other two PRs, the merging can proceed with them as well 👍

@psavidis psavidis assigned mboskamp and unassigned psavidis Dec 2, 2024
@mboskamp
Copy link
Member Author

mboskamp commented Dec 2, 2024

CI looks good on all branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue.
Projects
None yet
Development

No branches or pull requests

2 participants