Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a more useful message when I use the wrong secret format #3834

Closed
CatalinaMoisuc opened this issue Sep 7, 2023 · 5 comments · Fixed by #3885
Closed

Provide a more useful message when I use the wrong secret format #3834

CatalinaMoisuc opened this issue Sep 7, 2023 · 5 comments · Fixed by #3885
Assignees
Labels
enhancement New feature or request linting
Milestone

Comments

@CatalinaMoisuc
Copy link
Member

CatalinaMoisuc commented Sep 7, 2023

What should we do?

We should give the user a more helpful error message when they encounter issues when using secrets.

This was reported by multiple people in internal channels over the past few days. See here and here.

This seems to be related to the switch to the mustache-style format when using secrets:
https://docs.camunda.io/docs/components/connectors/use-connectors/#using-secrets

The current error we show when people use the old secrets format is the following:
Screenshot 2023-09-07 at 13 01 42

To mitigate this, we could add a link to the documentation page that explains how people can use the secrets correctly:
https://docs.camunda.io/docs/components/connectors/use-connectors/#using-secrets

Why should we do it?

To avoid confusion and ensure that our users are supported to quickly understand how they can fix the underlying issue.

@CatalinaMoisuc CatalinaMoisuc added the ready Ready to be worked on label Sep 7, 2023
@philippfromme
Copy link
Contributor

Related to camunda/bpmnlint-plugin-camunda-compat#133. What's missing is being able to show warnings instead of errors in the properties panel and to add the link to documentation.

@nikku
Copy link
Member

nikku commented Sep 11, 2023

Discussed today morning:

  • Let's not indicate warnings (or info) in the properties panel as an initial step. Instead keep them on the canvas + in the problems panel, and only focus the respective entry in the properties panel.

@CatalinaMoisuc
Copy link
Member Author

@philippfromme since you have the correct context on this issue, I will assign this one to you as a candidate for the next iteration. Let's ensure that we get a new PR that fixes the UX.

@CatalinaMoisuc
Copy link
Member Author

We can help the Connectors team to contribute with this. 😃

@nikku nikku added enhancement New feature or request linting labels Sep 19, 2023
@nikku nikku added this to the M69 milestone Sep 19, 2023
@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Sep 22, 2023
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 22, 2023
@philippfromme
Copy link
Contributor

philippfromme commented Sep 22, 2023

This requires two adjustments so we can ship it as part of @camunda/linting:

philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 22, 2023
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 22, 2023
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 22, 2023
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 22, 2023
merge-me bot pushed a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Sep 22, 2023
@philippfromme philippfromme added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Sep 25, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels Sep 26, 2023
@philippfromme philippfromme added the needs review Review pending label Sep 26, 2023 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Sep 26, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants