-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add console auth vars #1782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabouzaid
force-pushed
the
console-byo-oidc-auth-vars
branch
from
May 13, 2024 17:17
bd1bfd0
to
6b394ff
Compare
@aabouzaid Thanks for fixing the PR! The introduced vars are needed for a feature for console self-managed: byo oidc. Would be great if you can review it. |
aabouzaid
reviewed
May 15, 2024
aabouzaid
force-pushed
the
main
branch
7 times, most recently
from
June 6, 2024 14:29
f0da3dc
to
c374f10
Compare
aabouzaid
force-pushed
the
console-byo-oidc-auth-vars
branch
from
June 13, 2024 02:28
db06f13
to
4ad6ca6
Compare
Signed-off-by: Ahmed AbouZaid <[email protected]>
aabouzaid
force-pushed
the
console-byo-oidc-auth-vars
branch
from
June 13, 2024 02:33
4ad6ca6
to
3ab6f1b
Compare
aabouzaid
approved these changes
Jun 13, 2024
aabouzaid
added
the
version:10.2.0
Label that represents issues released on version 10.2.0
label
Jul 1, 2024
This was referenced Jul 2, 2024
Closed
aabouzaid
added a commit
that referenced
this pull request
Jul 13, 2024
* feat(console): add auth vars * feat(console): add auth vars * feat(console): add tests * fix(console): configmap test * fix(console): tests * fix(console): tests * fix(console): tests * fix(console): tests * update golden files --------- Co-authored-by: Ahmed AbouZaid <[email protected]>
This was referenced Jul 13, 2024
Closed
This was referenced Jul 25, 2024
github-actions
bot
added
version/8.5
Camunda applications/cycle version
version:10.4.0
labels
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/enhancement
New feature or request
version/8.5
Camunda applications/cycle version
version:10.2.0
Label that represents issues released on version 10.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
What's in this PR?
Running
make go.update-golden-only
leads to the following error:Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: