Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add console auth vars #1782

Merged
merged 12 commits into from
Jun 13, 2024
Merged

feat: add console auth vars #1782

merged 12 commits into from
Jun 13, 2024

Conversation

urbanisierung
Copy link
Member

@urbanisierung urbanisierung commented May 13, 2024

Which problem does the PR fix?

What's in this PR?

Running make go.update-golden-only leads to the following error:

make go.update-golden-only
Error: error unpacking identity in camunda-platform: Chart.yaml file is missing
make: *** [Makefile:97: helm.dependency-update] Error 1

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid changed the title feat(console): add auth vars feat: add console auth vars May 13, 2024
@aabouzaid aabouzaid added the kind/enhancement New feature or request label May 13, 2024
@urbanisierung urbanisierung marked this pull request as ready for review May 14, 2024 10:36
@urbanisierung urbanisierung enabled auto-merge (squash) May 14, 2024 10:37
@urbanisierung
Copy link
Member Author

@aabouzaid Thanks for fixing the PR! The introduced vars are needed for a feature for console self-managed: byo oidc. Would be great if you can review it.

@aabouzaid aabouzaid force-pushed the main branch 7 times, most recently from f0da3dc to c374f10 Compare June 6, 2024 14:29
Signed-off-by: Ahmed AbouZaid <[email protected]>
@urbanisierung urbanisierung merged commit 1bd65ca into main Jun 13, 2024
6 of 7 checks passed
@urbanisierung urbanisierung deleted the console-byo-oidc-auth-vars branch June 13, 2024 03:07
@aabouzaid aabouzaid added the version:10.2.0 Label that represents issues released on version 10.2.0 label Jul 1, 2024
aabouzaid added a commit that referenced this pull request Jul 13, 2024
* feat(console): add auth vars

* feat(console): add auth vars

* feat(console): add tests

* fix(console): configmap test

* fix(console): tests

* fix(console): tests

* fix(console): tests

* fix(console): tests

* update golden files

---------

Co-authored-by: Ahmed AbouZaid <[email protected]>
This was referenced Jul 13, 2024
@github-actions github-actions bot added version/8.5 Camunda applications/cycle version version:10.4.0 labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request version/8.5 Camunda applications/cycle version version:10.2.0 Label that represents issues released on version 10.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants