fix(openshift): make post-render script compatible with mac #1970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
This PR aims to address compatibility issues with the post-render script on macOS. Currently, the script does not function properly on macOS and does not return an error. To resolve this, we introduce the usage of
gsed
(GNUsed
) on macOS.Additionally, I propose an alternative approach to eliminate the need for the post-render script altogether by using a flag in the source control configuration (scc) to remove the attribute. This would simplify the process for end users as demonstrated in the example provided here.
What's in this PR?
This PR introduces compatibility for the post-render script on macOS by utilizing
gsed
(GNUsed
). This ensures that the script functions correctly across both macOS and Linux environments.Checklist
Please ensure that all items in the checklist are completed before and after opening the PR.
Before opening the PR:
make go.update-golden-only
in the repo's root dir.After opening the PR: