Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dnsPolicy and dnsConfig for all components #2009

Merged

Conversation

drodriguez-305
Copy link
Contributor

@drodriguez-305 drodriguez-305 commented Jun 17, 2024

Which problem does the PR fix?

Related to : #1678

What's in this PR?

Support the use for dnsPolicy and dnsConfig for all components.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@drodriguez-305 drodriguez-305 added the kind/enhancement New feature or request label Jun 17, 2024
@drodriguez-305 drodriguez-305 added this to the 8.6 Release Cycle milestone Jun 17, 2024
@drodriguez-305 drodriguez-305 self-assigned this Jun 17, 2024
@drodriguez-305 drodriguez-305 linked an issue Jun 17, 2024 that may be closed by this pull request
@drodriguez-305 drodriguez-305 force-pushed the 1678-task-support-dnspolicy-and-dnsconfig-in-all-components branch from ba67d06 to 237207c Compare June 20, 2024 20:39
@drodriguez-305 drodriguez-305 force-pushed the 1678-task-support-dnspolicy-and-dnsconfig-in-all-components branch from caf1b3e to 28cafbf Compare June 24, 2024 15:09
@drodriguez-305 drodriguez-305 requested a review from a team June 24, 2024 15:36
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍
For the failed test, I'm working on it in another PR, so it's ok.

@drodriguez-305 drodriguez-305 merged commit 31b7c4f into main Jun 24, 2024
19 of 20 checks passed
@drodriguez-305 drodriguez-305 deleted the 1678-task-support-dnspolicy-and-dnsconfig-in-all-components branch June 24, 2024 18:33
@aabouzaid aabouzaid added the version:10.2.0 Label that represents issues released on version 10.2.0 label Jul 1, 2024
aabouzaid pushed a commit that referenced this pull request Jul 13, 2024
* add dnsPolicy and dnsConfig to deployments and statefulsets

* add dnsPolicy and dnsConfig in values for each component

* add fix webmodeler name for params

* update README

* fixed empty space inside brackets

* fixed dnsPolicy with empty string and dnsConfig with empty object

* add unit test for console,connectors,identity,operate,optimze,tasklist

* add unit test for zeebe and webmodeler

* port to alpha

* update README

* fix unit test for console

* add missing unit test for zeebe-gateway deployment in latest

* backport unit tests to alpha
This was referenced Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request version:10.2.0 Label that represents issues released on version 10.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Support dnsPolicy and dnsConfig in all components
2 participants