-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dnsPolicy and dnsConfig for all components #2009
Merged
drodriguez-305
merged 13 commits into
main
from
1678-task-support-dnspolicy-and-dnsconfig-in-all-components
Jun 24, 2024
Merged
feat: support dnsPolicy and dnsConfig for all components #2009
drodriguez-305
merged 13 commits into
main
from
1678-task-support-dnspolicy-and-dnsconfig-in-all-components
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodriguez-305
force-pushed
the
1678-task-support-dnspolicy-and-dnsconfig-in-all-components
branch
from
June 20, 2024 20:39
ba67d06
to
237207c
Compare
drodriguez-305
force-pushed
the
1678-task-support-dnspolicy-and-dnsconfig-in-all-components
branch
from
June 24, 2024 15:09
caf1b3e
to
28cafbf
Compare
aabouzaid
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 👍
For the failed test, I'm working on it in another PR, so it's ok.
drodriguez-305
deleted the
1678-task-support-dnspolicy-and-dnsconfig-in-all-components
branch
June 24, 2024 18:33
aabouzaid
added
the
version:10.2.0
Label that represents issues released on version 10.2.0
label
Jul 1, 2024
This was referenced Jul 2, 2024
Closed
aabouzaid
pushed a commit
that referenced
this pull request
Jul 13, 2024
* add dnsPolicy and dnsConfig to deployments and statefulsets * add dnsPolicy and dnsConfig in values for each component * add fix webmodeler name for params * update README * fixed empty space inside brackets * fixed dnsPolicy with empty string and dnsConfig with empty object * add unit test for console,connectors,identity,operate,optimze,tasklist * add unit test for zeebe and webmodeler * port to alpha * update README * fix unit test for console * add missing unit test for zeebe-gateway deployment in latest * backport unit tests to alpha
This was referenced Jul 13, 2024
Closed
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/enhancement
New feature or request
version:10.2.0
Label that represents issues released on version 10.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Related to : #1678
What's in this PR?
Support the use for dnsPolicy and dnsConfig for all components.
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: