Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the global image tag value and use it from the components #2069

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Jun 26, 2024

Which problem does the PR fix?

Task: #2067

What's in this PR?

Now most of the Camunda application has its own patch version and it's expected to have this for all components.

Remove the global image tag value and use it from the components

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid self-assigned this Jun 26, 2024
@aabouzaid aabouzaid added version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version labels Jun 26, 2024
@aabouzaid aabouzaid force-pushed the 2067-aa-use-component-image-tag branch from d532b97 to a5debf5 Compare June 26, 2024 19:51
@aabouzaid aabouzaid marked this pull request as ready for review June 26, 2024 19:58
@aabouzaid aabouzaid merged commit 01301ac into main Jun 26, 2024
17 of 21 checks passed
@aabouzaid aabouzaid deleted the 2067-aa-use-component-image-tag branch June 26, 2024 19:58
aabouzaid added a commit that referenced this pull request Jun 27, 2024
aabouzaid added a commit that referenced this pull request Jun 28, 2024
@aabouzaid aabouzaid added version:10.2.0 Label that represents issues released on version 10.2.0 version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version labels Jul 1, 2024
aabouzaid added a commit that referenced this pull request Jul 13, 2024
This was referenced Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version version:10.2.0 Label that represents issues released on version 10.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant