Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not quote bool #2522

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: do not quote bool #2522

wants to merge 4 commits into from
+6 −12

Conversation

jonathanlukas
Copy link
Contributor

@jonathanlukas jonathanlukas commented Oct 30, 2024 •
edited
Loading

Which problem does the PR fix?

closes #2523

What's in this PR?

The user task access restrictions are a boolean, but are defined as a string. To fix this, the quote pipe has been removed.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@jonathanlukas jonathanlukas requested a review from a team October 30, 2024 08:22
@jonathanlukas jonathanlukas self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid Awaiting requested review from aabouzaid

At least 1 approving review is required to merge this pull request.

Assignees

@jonathanlukas jonathanlukas

Labels
component/tasklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Tasklist userAccessRestrictions can not be disabled.
1 participant
@jonathanlukas