feat: add "cargo" to deb build dependencies for charm plugin #2005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
"cargo"
to the charm plugin build dependencies for deb based charms.I don't know if a similar fix is needed for
yum
anddnf
systems -- review appreciated here.This will prevent various charm-libs from needing to document that including them requires adding
cargo
tobuild-packages
incharmcraft.yaml
, and prevent charmers from having to do this, sincecargo
will be included be default, and python packages requiring a rust compiler to build (e.g.pydantic
) will work out of the box.See issue: