Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "cargo" to deb build dependencies for charm plugin #2005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

james-garner-canonical
Copy link

This PR adds "cargo" to the charm plugin build dependencies for deb based charms.

I don't know if a similar fix is needed for yum and dnf systems -- review appreciated here.

This will prevent various charm-libs from needing to document that including them requires adding cargo to build-packages in charmcraft.yaml, and prevent charmers from having to do this, since cargo will be included be default, and python packages requiring a rust compiler to build (e.g. pydantic) will work out of the box.

See issue:

@lengau
Copy link
Collaborator

lengau commented Dec 5, 2024

This implementation may break a charm if the user installs their own cargo (and rustc) through another mechanism such as rustup, which might be required if the base has too old a version of rustc.

Please look at the way the poetry plugin and its environment validator implement the checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants